Fix malloc ISO C compliance: NULL on failure and max_align_t alignment #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mallocimplementation violated ISO C in two ways: it panicked instead of returning NULL on allocation failure, and used 8-byte alignment instead of the 16-byte alignment required formax_align_ton 64-bit platforms.Changes
assert!(!ptr.is_null())and added proper error handling to returncore::ptr::null_mut()when allocation fails or layout creation failsMALLOC_ALIGNMENTconstant usingtarget_pointer_widthcfg attribute (16 bytes for 64-bit, 8 bytes for 32-bit)free()to useMALLOC_ALIGNMENTinstead of hardcoded valueOriginal prompt
malloc#306✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.